revert: reject neutral symbol-id series storage
This commit is contained in:
boris
@@ -1,118 +0,0 @@
|
||||
{
|
||||
"schemaVersion": "fidc-symbol-id-series-storage/v1",
|
||||
"measuredAt": "2026-09-06T06:25:00+08:00",
|
||||
"host": "192.168.31.177",
|
||||
"engineCommit": "5a7c49a",
|
||||
"serviceCommit": "61a478839674ab03356083fb777840342ad4c726",
|
||||
"implementation": {
|
||||
"description": "build market and adjusted-close series directly in immutable symbol-id vectors and route string helpers through the canonical symbol-id index",
|
||||
"removedStructures": [
|
||||
"market_series_by_symbol AHashMap",
|
||||
"adjusted_close_series_by_symbol AHashMap",
|
||||
"second Arc copy from string maps into symbol-id vectors"
|
||||
],
|
||||
"publicDataHelpersChanged": false,
|
||||
"rollingSemanticsChanged": false,
|
||||
"adjustmentSemanticsChanged": false,
|
||||
"pitSemanticsChanged": false,
|
||||
"selectionResultsCached": false,
|
||||
"netSourceLines": -10
|
||||
},
|
||||
"adjacentBaseline": {
|
||||
"engineCommit": "cda249e9b4458770361b4cad570bd1e52f9eb67a",
|
||||
"runs": [
|
||||
{
|
||||
"runId": "btr_1788645721278_2764691_0",
|
||||
"totalSeconds": 18.207,
|
||||
"dataSeconds": 14.052,
|
||||
"datasetConstructSeconds": 4.448
|
||||
},
|
||||
{
|
||||
"runId": "btr_1788646439501_2764691_2",
|
||||
"totalSeconds": 17.858,
|
||||
"dataSeconds": 13.878,
|
||||
"datasetConstructSeconds": 4.546
|
||||
}
|
||||
],
|
||||
"datasetConstructMedianSeconds": 4.497
|
||||
},
|
||||
"primaryFiveYearContract": {
|
||||
"runId": "btr_1788646914659_2773606_0",
|
||||
"totalReturn": 0.9219861819172002,
|
||||
"tradeCount": 26088,
|
||||
"canonicalSha256": "b42fea66237d06eadb24f6b8c9e2760e7319fe3699f315b99e01f433ef2aa234",
|
||||
"resultStoreSha256": "9ccf0c0fc6f5d72e974381ad4cd09a80241d7de99f2649f2b01736f7c80dc2c7",
|
||||
"coldTotalSeconds": 16.322,
|
||||
"coldDataSeconds": 12.815,
|
||||
"datasetConstructSeconds": 3.899,
|
||||
"hotTotalMedianSeconds": 3.402,
|
||||
"hotEngineMedianSeconds": 2.792,
|
||||
"terminalAuditStatus": "clean",
|
||||
"resultConsistent": true
|
||||
},
|
||||
"secondaryFiveYearContract": {
|
||||
"runId": "btr_1788646986983_2773606_4",
|
||||
"totalReturn": 1.1342962298106998,
|
||||
"tradeCount": 19404,
|
||||
"canonicalSha256": "0dbd3fad624097c673c4a5ec2f545f95e9c21d1d5337bb2b48ffeb22b16cb2b9",
|
||||
"resultStoreSha256": "dd744dd6710bc28bb4ecd9ca912051292b9a1eefa0056e02c62a38cad85cf435",
|
||||
"coldTotalSeconds": 15.292,
|
||||
"coldDataSeconds": 12.238,
|
||||
"datasetConstructSeconds": 3.895,
|
||||
"terminalAuditStatus": "clean",
|
||||
"resultConsistent": true
|
||||
},
|
||||
"genericRankFiveYearContract": {
|
||||
"runId": "btr_1788647058500_2773606_8",
|
||||
"rankBy": "free_float_cap",
|
||||
"totalReturn": 0.7140315244542004,
|
||||
"tradeCount": 21876,
|
||||
"canonicalSha256": "84367993911b42437939aad88f29379d007af6f5f171667ff7ad6677dd488fd2",
|
||||
"resultStoreSha256": "865c00f81d17153285e391eb48ea51487e33fd3bba55a6c2a0ca280b07511077",
|
||||
"coldTotalSeconds": 16.739,
|
||||
"coldDataSeconds": 11.512,
|
||||
"datasetConstructSeconds": 3.663,
|
||||
"terminalAuditStatus": "clean",
|
||||
"resultConsistent": true
|
||||
},
|
||||
"minuteContract": {
|
||||
"runId": "btr_1788647032685_2773606_6",
|
||||
"totalReturn": 0.03473222656500008,
|
||||
"tradeCount": 156,
|
||||
"canonicalSha256": "457c086b1bca784fe83f447bb22451925e8f022456bb0fc7b54237a7a7886849",
|
||||
"resultStoreSha256": "a77894eecf4e6a49168a38ff83cf27226e274b6850e10196892efa7d95be91cd",
|
||||
"coldTotalSeconds": 0.814,
|
||||
"hotTotalSeconds": 0.543,
|
||||
"terminalAuditStatus": "clean",
|
||||
"resultConsistent": true
|
||||
},
|
||||
"performance": {
|
||||
"candidateDatasetConstructSeconds": [3.899, 3.895, 3.663],
|
||||
"candidateDatasetConstructMedianSeconds": 3.895,
|
||||
"datasetConstructMedianImprovementPercent": 13.386702,
|
||||
"primaryColdDataImprovementPercent": 7.659605,
|
||||
"primaryColdTotalImprovementPercent": 8.601187,
|
||||
"wallComparisonsIncludeHostLoadVariance": true
|
||||
},
|
||||
"memory": {
|
||||
"singleDatasetCandidateCurrentBytes": 11495055360,
|
||||
"singleDatasetBaselineCurrentBytes": 11470495744,
|
||||
"comparison": "within allocator and concurrent workload variance; no memory reduction claimed",
|
||||
"repeatedManualCacheClearHighWaterExcluded": true
|
||||
},
|
||||
"testGate": {
|
||||
"corePassed": 538,
|
||||
"ignoredManualBenchmarks": 8,
|
||||
"failed": 0
|
||||
},
|
||||
"remoteArtifacts": [
|
||||
"/srv/fidc/canonical/run/fidc-private/evidence/symbol-id-series-primary-five-year-20260906.json",
|
||||
"/srv/fidc/canonical/run/fidc-private/evidence/symbol-id-series-secondary-five-year-20260906.json",
|
||||
"/srv/fidc/canonical/run/fidc-private/evidence/symbol-id-series-generic-rank-five-year-20260906.json",
|
||||
"/srv/fidc/canonical/run/fidc-private/evidence/symbol-id-series-minute-20260906.json"
|
||||
],
|
||||
"acceptance": {
|
||||
"status": "accepted",
|
||||
"reason": "three independent cold five-year builds reduce DataSet construction time, four distinct strategy contracts preserve exact canonical outputs, and duplicate string-keyed series indexes are removed rather than hidden behind another cache"
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,45 @@
|
||||
{
|
||||
"schemaVersion": "fidc-symbol-id-series-storage-rejection/v1",
|
||||
"measuredAt": "2026-09-06T06:31:00+08:00",
|
||||
"host": "192.168.31.177",
|
||||
"candidateCommit": "5a7c49a4543b584503ff0d2c2ae513c68d25de8a",
|
||||
"implementation": "remove duplicate string-keyed market and adjusted-close series maps and build symbol-id vectors directly",
|
||||
"businessParity": {
|
||||
"primaryFiveYearCanonicalSha256": "b42fea66237d06eadb24f6b8c9e2760e7319fe3699f315b99e01f433ef2aa234",
|
||||
"secondaryFiveYearCanonicalSha256": "0dbd3fad624097c673c4a5ec2f545f95e9c21d1d5337bb2b48ffeb22b16cb2b9",
|
||||
"genericRankFiveYearCanonicalSha256": "84367993911b42437939aad88f29379d007af6f5f171667ff7ad6677dd488fd2",
|
||||
"minuteCanonicalSha256": "457c086b1bca784fe83f447bb22451925e8f022456bb0fc7b54237a7a7886849",
|
||||
"allTerminalAuditsClean": true,
|
||||
"allResultsConsistent": true
|
||||
},
|
||||
"performance": {
|
||||
"baselineDatasetConstructSeconds": [4.448, 4.546],
|
||||
"candidateEarlyDatasetConstructSeconds": [3.899, 3.895, 3.663],
|
||||
"candidateFinalRestartDatasetConstructSeconds": 4.472,
|
||||
"candidateFinalRestartColdDataSeconds": 14.513,
|
||||
"candidateFinalRestartColdTotalSeconds": 18.381,
|
||||
"conclusion": "the apparent early improvement did not reproduce after a final restart under the current host phase; the final constructor time is equal to the adjacent baseline range"
|
||||
},
|
||||
"memory": {
|
||||
"baselineSingleDatasetCurrentBytes": 11470495744,
|
||||
"candidateSingleDatasetCurrentBytes": 11473674240,
|
||||
"conclusion": "no measurable resident-memory reduction"
|
||||
},
|
||||
"testGate": {
|
||||
"corePassed": 538,
|
||||
"ignoredManualBenchmarks": 8,
|
||||
"failed": 0
|
||||
},
|
||||
"remoteArtifacts": [
|
||||
"/srv/fidc/canonical/run/fidc-private/evidence/symbol-id-series-primary-five-year-20260906.json",
|
||||
"/srv/fidc/canonical/run/fidc-private/evidence/symbol-id-series-secondary-five-year-20260906.json",
|
||||
"/srv/fidc/canonical/run/fidc-private/evidence/symbol-id-series-generic-rank-five-year-20260906.json",
|
||||
"/srv/fidc/canonical/run/fidc-private/evidence/symbol-id-series-minute-20260906.json",
|
||||
"/srv/fidc/canonical/run/fidc-private/evidence/final-symbol-id-series-post-doc-sync-20260906.json"
|
||||
],
|
||||
"decision": {
|
||||
"status": "rejected_and_removed",
|
||||
"reason": "the candidate preserved correctness but did not provide a stable end-to-end or memory improvement across restart validation; duplicate maps are not a proven material bottleneck",
|
||||
"nextTarget": "remove the SourceRowRecord to DailySnapshot to DataSet multi-stage materialization, or publish a content-addressed base panel that can be mapped across restarts"
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user